Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Logout flow #6250

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: Logout flow #6250

merged 1 commit into from
Oct 2, 2024

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 1, 2024

What does this PR change?

This PR fixes the logout flow. Doing the window.location.reload() in the logout method avoids the provider disconnection handled in the explorer-website app through the globalObservable.emit('logout', { address: identity.address, network }).

How to test the changes?

Locally:

  1. Run the command: make npm-link in the browser-interface folder
  2. Copy the version from browser-interface/static/package.json file
  3. Paste the version in the .env file in the explorer-website project folder
    3.1 VITE_APP_EXPLORER_VERSION
    3.2 VITE_APP_EXPLORER_BASE_URL
  4. Run the command: npm link @dcl/explorer in the explorer-website project folder
  5. Run the command: npm run copy-cdn in the explorer-website project folder
  6. Launch the explorer-website app and test the login and logout flow using WalletConnect as provider

Using the preview-branch:

  1. Login using WalletConnect as provider, it should show a Modal with a QR code
  2. Logout
  3. Login again using WalletConnect as provider, it should show a Modal with a QR code

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copilot summary

copilot:summary

@cyaiox cyaiox force-pushed the fix/logout branch 2 times, most recently from 312e279 to 110a3ad Compare October 2, 2024 14:26
@cyaiox cyaiox changed the title [WIP] fix: Logout process fix: Logout flow Oct 2, 2024
@cyaiox cyaiox marked this pull request as ready for review October 2, 2024 14:29
Copy link
Contributor

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Fix verified on Windows. Approved by QA.

6250.mp4

@aixaCode aixaCode merged commit 0dbfb81 into dev Oct 2, 2024
12 checks passed
@aixaCode aixaCode deleted the fix/logout branch October 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants