Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR fixes the logout flow. Doing the
window.location.reload()
in thelogout
method avoids the provider disconnection handled in the explorer-website app through theglobalObservable.emit('logout', { address: identity.address, network })
.How to test the changes?
Locally:
make npm-link
in thebrowser-interface
folderbrowser-interface/static/package.json
file.env
file in theexplorer-website
project folder3.1 VITE_APP_EXPLORER_VERSION
3.2 VITE_APP_EXPLORER_BASE_URL
npm link @dcl/explorer
in theexplorer-website
project foldernpm run copy-cdn
in theexplorer-website
project folderexplorer-website
app and test the login and logout flow using WalletConnect as providerUsing the preview-branch:
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md
Copilot summary
copilot:summary